migrate to uWebSockets.js #583
Conversation
|
UWS and uWebsocket.js has different structure and methods/getters/setters names. My idea was to create wrappers for all classes uWebsocket.js offers to make it compatible with ws, then swaping will be the easiest part. I guess it is not all that needs to be done: An HttpRequest is stack allocated and only accessible during the callback invocation. engine.io keeps a copy of request in some cases, this also has to be taken into account Also uWebsocket.js offers general http requests by uSocket library that is faster than http module in node.js |
|
@shirtleton we also had this problem. We didn't want to step over to the javascript ws package and we created a new uws package and added support for node 10 and node 12. |
uws is no longer maintained, and does not support Node.js >= 10. We could also try to support uWebSockets.js, but it does not have the same API as ws. Source: https://github.com/mmdevries/uws Related: #583
|
Any news? Still waiting for merge :-) |
|
@mmdevries thanks a lot for the hard work on this ❤️ I tried to use The commit itself: 048c674 Node.js 8 & 10 are good though. |
|
@Kamil93 were you able to create this wrapper? Could you please share it if that's the case? |
uws is no longer maintained, and does not support Node.js >= 10. We could also try to support uWebSockets.js, but it does not have the same API as ws. Source: https://github.com/mmdevries/uws Related: #583
uws is no longer maintained, and did not support Node.js >= 10. We now use a fork in order to support the newer versions of Node.js. It is maintained there: https://github.com/mmdevries/uws And can be installed with: `npm i github:mmdevries/uws#2.4.1` We could also try to support uWebSockets.js, but it does not have the same API as ws. The "engines" attribute has also been added in the package.json file, since we broke the support for Node.js 6 in the latest minor release. Source: https://github.com/mmdevries/uws Related: #583
|
@darrachequesne there seemed to be some timing issue on node 12 which is solved now (version 2.4.2). Can you verify this? |
|
@mmdevries still no luck:
If you ever have time to check. |
|
@darrachequesne I've updated the node headers on version 12 and re-added support for node13. This should hopefully solve the problem. Version 2.9.11 |
|
There is a new npm module which you can try: eiows |
|
@mmdevries is it battle tested in some projects? |
|
@Kamil93 we use it on many production systems already without problems. |
This PR is not necessarily meant to merged but rather to continue the conversation with code rather than speculating and ghosting on issues. I believe a lot of us are waiting on some type of answer and personally, switching to
wsas the background WebSocket engine is not an acceptable performance loss.*Failing test was failing before changes were made.
The kind of change this PR does introduce
Current behaviour
uwsis no longer maintainedNew behaviour
Migrate to
uWebSockets.js- the latest iteration ofuwsfor the Node ecosystem.Other information (e.g. related issues)
#578
#575
#567
#560
socketio/socket.io#3342
The internet